Skip to content

chore: run test suite on windows#3479

Merged
benjamincanac merged 19 commits into
v3from
fix-windows-dev
Apr 10, 2025
Merged

chore: run test suite on windows#3479
benjamincanac merged 19 commits into
v3from
fix-windows-dev

Conversation

@sandros94

@sandros94 sandros94 commented Mar 7, 2025

Copy link
Copy Markdown
Member

🔗 Linked issue

Related: nuxt/ecosystem-ci#15

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This both fixes the development of Nuxt UI on windows as well as run CI tests on windows-latest too

TODO

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@sandros94 sandros94 self-assigned this Mar 7, 2025
@sandros94 sandros94 added the v3 #1289 label Mar 7, 2025
@pkg-pr-new

pkg-pr-new Bot commented Mar 7, 2025

Copy link
Copy Markdown
npm i https://pkg.pr.new/@nuxt/ui@3479

commit: 79daffd

@nuxthub-admin

nuxthub-admin Bot commented Mar 7, 2025

Copy link
Copy Markdown
Contributor

✅ Deployed ui3

Deployed ui3 79daffd to preview

🔗 fix-windows-dev.ui-6q2.pages.dev
📌 10d5430b.ui-6q2.pages.dev
📱
View QR Code QR code linking to deployment URL.

📋 View deployment logs

This reverts commit 9e24c40.
@sandros94

Copy link
Copy Markdown
Member Author

@danielroe upgrading to @nuxt/module-builder@1.0.0-alpha.1 did indeed solve the issue (alongside an upstream fix from nuxt-component-meta).

unbuild v3 works great but this also introduced mkdist v2, which atm doesn't support typescript in templates (mkdist#281). Is it safe to pin mkdist to v1.6 while using unbuild v3 and moudle-builder v1 alpha?

@sandros94 sandros94 marked this pull request as ready for review March 31, 2025 19:09
@sandros94 sandros94 marked this pull request as draft March 31, 2025 19:25
@sandros94 sandros94 marked this pull request as ready for review April 4, 2025 22:10
@sandros94 sandros94 marked this pull request as draft April 4, 2025 22:46
Comment thread .github/workflows/docs.yml Outdated
@benjamincanac benjamincanac changed the title ci: run test suite on windows chore(github): run test suite on windows Apr 8, 2025
@benjamincanac benjamincanac changed the title chore(github): run test suite on windows chore: run test suite on windows Apr 8, 2025
Co-authored-by: Benjamin Canac <canacb1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v3 #1289

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants