chore: h3-next to optional dependencies#1733
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
commit: |
e61d959 to
bc552f8
Compare
📝 WalkthroughWalkthrough
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed: private package registry requires authentication. Disable ESLint in CodeRabbit settings or use public packages. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
package.json (1)
142-142: 🗄️ Data Integrity & Integration | 🔵 Trivial | ⚡ Quick winConstrain the peer range to h3 v2.
The runtime imports
h3-next/generic, constructsH3, and callsh3App.fetch, so this is a v2-specific contract.>=2.0.1-rc.22also admits future major versions that may be incompatible. Use>=2.0.1-rc.22 <3or an equivalent v2-only range.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@package.json` at line 142, Constrain the h3-next peer dependency range to v2 by adding an upper bound below version 3, while retaining the existing minimum version 2.0.1-rc.22.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Around line 167-169: Update the H3 v2 loading logic in
src/runtime/shared/h3-v2.ts to catch failures from the bare dynamic import of
optional h3-next and re-throw an error with a clear installation hint when the
package is missing. Preserve the existing behavior for successful imports and
unrelated import failures.
---
Nitpick comments:
In `@package.json`:
- Line 142: Constrain the h3-next peer dependency range to v2 by adding an upper
bound below version 3, while retaining the existing minimum version 2.0.1-rc.22.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 6eecee8c-ecda-4a9e-8319-7b8e4eb6897e
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (1)
package.json
🔗 Linked issue
resolves #1711
📚 Description
Tested and reproduced. It took a few clean installs and cache clears, but I confirmed the behavior.
