Skip to content

chore: drop pkg.pr.new nitro resolution#1681

Merged
danielroe merged 1 commit into
mainfrom
test/nitro-res
Apr 28, 2026
Merged

chore: drop pkg.pr.new nitro resolution#1681
danielroe merged 1 commit into
mainfrom
test/nitro-res

Conversation

@danielroe

@danielroe danielroe commented Apr 28, 2026

Copy link
Copy Markdown
Member

🔗 Linked issue

📚 Description

missed the resolution in #1678!

also moved resolutions -> overrides in pnpm-workspace.yaml

@pkg-pr-new

pkg-pr-new Bot commented Apr 28, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/test-utils@1681
npm i https://pkg.pr.new/vitest-environment-nuxt@1681

commit: 81e4983

@socket-security

Copy link
Copy Markdown

@coderabbitai

coderabbitai Bot commented Apr 28, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a23a799a-97b3-4d54-98e8-caa355674aac

📥 Commits

Reviewing files that changed from the base of the PR and between 1e1b22e and 81e4983.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (2)
  • package.json
  • pnpm-workspace.yaml
💤 Files with no reviewable changes (1)
  • package.json

📝 Walkthrough

Walkthrough

The pull request relocates dependency version pinning from package.json to pnpm-workspace.yaml. The resolutions override section in package.json (covering 9 packages and 1 workspace override) is removed and relocated to a new overrides section in pnpm-workspace.yaml with identical version specifications. This changes the scope of version constraints from package-level to workspace-level configuration without modifying the actual pinned versions.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore: drop pkg.pr.new nitro resolution' accurately describes the primary change: removing a nitro resolution from the package configuration.
Description check ✅ Passed The description is related to the changeset, mentioning removal of a resolution and migration of resolutions to overrides in pnpm-workspace.yaml, which aligns with the actual changes made.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch test/nitro-res

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@danielroe danielroe merged commit f7b200f into main Apr 28, 2026
10 checks passed
@danielroe danielroe deleted the test/nitro-res branch April 28, 2026 15:38
@github-actions github-actions Bot mentioned this pull request Apr 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant