Skip to content

fix(nuxt): hide unhandled error messages in prod#28156

Merged
danielroe merged 9 commits into
mainfrom
fix/unhandled-errors
Jul 17, 2024
Merged

fix(nuxt): hide unhandled error messages in prod#28156
danielroe merged 9 commits into
mainfrom
fix/unhandled-errors

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

nitrojs/nitro#2591

📚 Description

This applies a fix made in nitro to our forked version of error utility. From @pi0:

We should hide error messages (to client) in case of unhandled errors because they can include internal server state.

Thanks for @GalacticHypernova for discovering this! (issue was if a chunk is missing, we were showing full path but it can be extended to other causes)

Note: This might be a minor behavior change but since we only hide unhandled errors, (new Error not createError) i guess should be safe for v2 as patch.

@danielroe danielroe added 🐛 bug Something isn't working as expected nitro Nitro server engine integration labels Jul 15, 2024
@danielroe danielroe self-assigned this Jul 15, 2024
@bolt-new-by-stackblitz

Copy link
Copy Markdown

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions github-actions Bot added the 3.x label Jul 15, 2024
Comment thread test/basic.test.ts Outdated
@danielroe
danielroe merged commit 42ef331 into main Jul 17, 2024
@danielroe
danielroe deleted the fix/unhandled-errors branch July 17, 2024 11:13
@github-actions github-actions Bot mentioned this pull request Jul 17, 2024
Kamsou pushed a commit to Kamsou/nuxt that referenced this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.x 🐛 bug Something isn't working as expected nitro Nitro server engine integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants