fix(cloudinary): handle blur modifier correctly - #985
Merged
Conversation
PatrikBird
marked this pull request as draft
September 14, 2023 14:26
PatrikBird
force-pushed
the
fix/placeholder-for-cloudinary
branch
from
September 15, 2023 05:40
71f8257 to
c01da88
Compare
PatrikBird
commented
Sep 15, 2023
PatrikBird
force-pushed
the
fix/placeholder-for-cloudinary
branch
from
September 15, 2023 05:52
c01da88 to
ce8e2ab
Compare
PatrikBird
marked this pull request as ready for review
September 27, 2023 07:14
PatrikBird
changed the title
Baroshem
reviewed
Sep 28, 2023
Baroshem
left a comment
Baroshem
left a comment
Collaborator
There was a problem hiding this comment.
Hey, very good Pr, please take a look at the comment I added :)
Co-authored-by: Jakub Andrzejewski <jakub.andrzejewski.dev@gmail.com>
PatrikBird
force-pushed
the
fix/placeholder-for-cloudinary
branch
from
September 28, 2023 12:39
a8a9ce5 to
f9c15de
Compare
Baroshem
approved these changes
Sep 28, 2023
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #985 +/- ##
=======================================
Coverage 89.91% 89.91%
=======================================
Files 44 44
Lines 2905 2906 +1
Branches 328 328
=======================================
+ Hits 2612 2613 +1
Misses 292 292
Partials 1 1
☔ View full report in Codecov by Sentry. |
danielroe
changed the title
danielroe
approved these changes
Sep 29, 2023
Closed
riddla
pushed a commit
to tricks-gmbh/nuxt-image
that referenced
this pull request
Mar 1, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #983