feat!: switch sizes default to responsive-first - #977
Merged
Conversation
Deploying with
|
| Latest commit: |
56087cf
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://075ac7a8.nuxt-image.pages.dev |
| Branch Preview URL: | https://feat-responsive-defaults.nuxt-image.pages.dev |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #977 +/- ##
==========================================
+ Coverage 89.15% 89.22% +0.06%
==========================================
Files 44 44
Lines 2914 2913 -1
Branches 323 325 +2
==========================================
+ Hits 2598 2599 +1
+ Misses 315 313 -2
Partials 1 1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
It looks good to me. What changes are required in the docs? |
Member
Author
|
Will update 👍 |
✅ Live Preview ready!
|
pi0
approved these changes
Sep 13, 2023
pi0
left a comment
pi0
left a comment
Member
There was a problem hiding this comment.
overall looks a good idea to base on smaller sizes 👍🏼
danielroe
changed the title
sizes default to responsive-first
Merged
riddla
pushed a commit
to tricks-gmbh/nuxt-image
that referenced
this pull request
Mar 1, 2024
This was referenced Apr 22, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #645
This aims to enable responsive sizing by default. It has two breaking changes:
sizes="100vw") are interpreted as a responsive minimum size, e.g.1px:100vw.sizes="md:100px lg:200px"means that the image is displayed at100pxby default. And atlgand above, at200px. (Previously, this meant that it was displayed at 100px only up tomd, and then displayed at200pxfor all sizes above that.)As these are both significant changes from previous behaviour, special care is requested in evaluating the API and DX.