Skip to content

feat: add apiVersion to cloudimage provider - #955

Merged
danielroe merged 16 commits into
nuxt:mainfrom
TiborPL:feat/add-apiversion-to-cloudimage
Sep 7, 2023
Merged

feat: add apiVersion to cloudimage provider#955
danielroe merged 16 commits into
nuxt:mainfrom
TiborPL:feat/add-apiversion-to-cloudimage

Conversation

@TiborPL

@TiborPL TiborPL commented Aug 29, 2023

Copy link
Copy Markdown
Contributor

Newly created Cloudimage tokens don't need v7 in url which was hardcoded.
Made optional option apiVersion. Kept v7 as default so not to break old codes.

Also clarified the documentation regarding new tokens and api version.

👉 Migration

If you have been using cloudimage provider with a legacy token, you will need to add the apiVersion: 'v7' to your nuxt.config:

  export default defineNuxtConfig({
    modules: ['@nuxt/image'],
    image: {
      cloudimage: {
        token: 'demo',
        baseURL: 'sample.li',
+       apiVersion: 'v7'
      },
    }
  })

@ghost

ghost commented Aug 29, 2023

Copy link
Copy Markdown

Live Preview ready!

Name Edit Preview Latest Commit
Image Edit on Studio ↗︎ View Live Preview 5ee9943

Comment thread docs/content/3.providers/cloudimage.md Outdated

@danielroe danielroe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would probably be fine to change the default behaviour as a breaking change pre v1 release.

@TiborPL
TiborPL requested a review from danielroe August 30, 2023 01:43
Comment thread docs/content/3.providers/cloudimage.md Outdated
Comment thread docs/content/3.providers/cloudimage.md Outdated
Comment thread docs/content/3.providers/cloudimage.md Outdated
Comment thread docs/content/3.providers/cloudimage.md Outdated
Comment thread docs/content/3.providers/cloudimage.md Outdated
Comment thread src/runtime/providers/cloudimage.ts Outdated
@TiborPL
TiborPL requested a review from danielroe August 30, 2023 17:52
@danielroe danielroe changed the title feat: add apiVersion to Cloudimage provider feat: add apiVersion to cloudimage provider Sep 7, 2023
@danielroe
danielroe merged commit c38b496 into nuxt:main Sep 7, 2023
@danielroe danielroe mentioned this pull request Sep 13, 2023
riddla pushed a commit to tricks-gmbh/nuxt-image that referenced this pull request Mar 1, 2024
@github-actions github-actions Bot mentioned this pull request Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants