feat: add apiVersion to cloudimage provider - #955
Merged
Conversation
✅ Live Preview ready!
|
danielroe
reviewed
Aug 29, 2023
danielroe
reviewed
Aug 29, 2023
danielroe
left a comment
Member
There was a problem hiding this comment.
I think it would probably be fine to change the default behaviour as a breaking change pre v1 release.
…m/TiborPL/image into feat/add-apiversion-to-cloudimage
danielroe
reviewed
Aug 30, 2023
danielroe
reviewed
Aug 30, 2023
danielroe
reviewed
Aug 30, 2023
danielroe
reviewed
Aug 30, 2023
danielroe
reviewed
Aug 30, 2023
danielroe
reviewed
Aug 30, 2023
danielroe
approved these changes
Sep 7, 2023
apiVersion to Cloudimage providerapiVersion to cloudimage provider
Merged
riddla
pushed a commit
to tricks-gmbh/nuxt-image
that referenced
this pull request
Mar 1, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newly created Cloudimage tokens don't need
v7in url which was hardcoded.Made optional option
apiVersion.Keptv7as default so not to break old codes.Also clarified the documentation regarding new tokens and api version.
👉 Migration
If you have been using
cloudimageprovider with a legacy token, you will need to add theapiVersion: 'v7'to your nuxt.config:export default defineNuxtConfig({ modules: ['@nuxt/image'], image: { cloudimage: { token: 'demo', baseURL: 'sample.li', + apiVersion: 'v7' }, } })