Skip to content

fix: respect densities prop with <nuxt-picture> - #928

Merged
danielroe merged 4 commits into
nuxt:mainfrom
ausir0726:fix-picture-miss-densities
Sep 7, 2023
Merged

fix: respect densities prop with <nuxt-picture>#928
danielroe merged 4 commits into
nuxt:mainfrom
ausir0726:fix-picture-miss-densities

Conversation

@ausir0726

@ausir0726 ausir0726 commented Jul 24, 2023

Copy link
Copy Markdown
Contributor

resolves #927

and I saw the merged commit bc3d333#diff-3fc0f6b5f15d4b824465eac0cc09094d1a5889ad6867b3b9e908512b5aab47ddR47
not include nuxt-picture compoment.

@netlify

netlify Bot commented Jul 24, 2023

Copy link
Copy Markdown

Deploy Preview for nuxt-image ready!

Name Link
🔨 Latest commit 656a511
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-image/deploys/64e3c4ed93a1980008b5c738
😎 Deploy Preview https://deploy-preview-928--nuxt-image.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov-commenter

codecov-commenter commented Jul 27, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (cb96767) 89.71% compared to head (656a511) 89.72%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #928   +/-   ##
=======================================
  Coverage   89.71%   89.72%           
=======================================
  Files          44       44           
  Lines        2879     2880    +1     
  Branches      320      320           
=======================================
+ Hits         2583     2584    +1     
  Misses        295      295           
  Partials        1        1           
Files Changed Coverage Δ
src/runtime/components/nuxt-picture.ts 82.45% <100.00%> (+0.15%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ausir0726

Copy link
Copy Markdown
Contributor Author

Is there anything I can do to keep this going?

@atinux atinux changed the title add densities for nuxt-picture feat: add densities for nuxt-picture Aug 21, 2023
@danielroe danielroe changed the title feat: add densities for nuxt-picture fix: respect densities prop with <nuxt-picture> Sep 7, 2023
@danielroe
danielroe merged commit 710a68e into nuxt:main Sep 7, 2023
@danielroe danielroe mentioned this pull request Sep 13, 2023
riddla pushed a commit to tricks-gmbh/nuxt-image that referenced this pull request Mar 1, 2024
@github-actions github-actions Bot mentioned this pull request Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

nuxt-picture don't support densities setting, only on nuxt-img

4 participants