Conversation
👷 Deploy request for nuxt-image pending review.Visit the deploys page to approve it
|
danielroe
requested changes
Sep 7, 2023
danielroe
left a comment
Member
There was a problem hiding this comment.
Would you check the failing CI? It might just be a matter of updating snapshots.
Collaborator
Author
|
I tried to work on this Pr right now but I recently changed laptop to a newer one where I am experiencing some issues with the sharp library which blocks me from further working on this. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #920 +/- ##
=======================================
Coverage 89.18% 89.18%
=======================================
Files 44 44
Lines 2904 2904
Branches 322 321 -1
=======================================
Hits 2590 2590
Misses 313 313
Partials 1 1
☔ View full report in Codecov by Sentry. |
danielroe
approved these changes
Sep 9, 2023
sizes is provided
Merged
riddla
pushed a commit
to tricks-gmbh/nuxt-image
that referenced
this pull request
Mar 1, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related #645