Skip to content

fix: generate sizes when only a single sizes is provided - #920

Merged
danielroe merged 4 commits into
nuxt:mainfrom
Baroshem:main
Sep 11, 2023
Merged

fix: generate sizes when only a single sizes is provided#920
danielroe merged 4 commits into
nuxt:mainfrom
Baroshem:main

Conversation

@Baroshem

@Baroshem Baroshem commented Jul 19, 2023

Copy link
Copy Markdown
Collaborator

related #645

@netlify

netlify Bot commented Jul 19, 2023

Copy link
Copy Markdown

👷 Deploy request for nuxt-image pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 2f80b2f

@danielroe danielroe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you check the failing CI? It might just be a matter of updating snapshots.

@Baroshem

Baroshem commented Sep 7, 2023

Copy link
Copy Markdown
Collaborator Author

@danielroe

I tried to work on this Pr right now but I recently changed laptop to a newer one where I am experiencing some issues with the sharp library which blocks me from further working on this.

[error] 
Something went wrong installing the "sharp" module

Cannot find module '../build/Release/sharp-darwin-arm64v8.node'
Require stack:
- /image/node_modules/.pnpm/sharp@0.32.1/node_modules/sharp/lib/sharp.js
- /image/node_modules/.pnpm/sharp@0.32.1/node_modules/sharp/lib/constructor.js
- /image/node_modules/.pnpm/sharp@0.32.1/node_modules/sharp/lib/index.js

Possible solutions:
- Install with verbose logging and look for errors: "npm install --ignore-scripts=false --foreground-scripts --verbose sharp"
- Install for the current darwin-arm64v8 runtime: "npm install --platform=darwin --arch=arm64v8 sharp"
- Consult the installation documentation: https://sharp.pixelplumbing.com/install

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (576aaf3) 89.18% compared to head (da999d4) 89.18%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #920   +/-   ##
=======================================
  Coverage   89.18%   89.18%           
=======================================
  Files          44       44           
  Lines        2904     2904           
  Branches      322      321    -1     
=======================================
  Hits         2590     2590           
  Misses        313      313           
  Partials        1        1           
Files Changed Coverage Δ
src/runtime/image.ts 86.13% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielroe danielroe changed the title fix: sizes not being generated (and also srcset) fix: generate sizes when only a single sizes is provided Sep 9, 2023
@danielroe
danielroe merged commit 7e1eea1 into nuxt:main Sep 11, 2023
@danielroe danielroe mentioned this pull request Sep 13, 2023
riddla pushed a commit to tricks-gmbh/nuxt-image that referenced this pull request Mar 1, 2024
@github-actions github-actions Bot mentioned this pull request Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants