Skip to content

feat: allow setting global quality defaults in config - #884

Merged
danielroe merged 2 commits into
nuxt:mainfrom
Tragio:feat/global-quality
Jun 21, 2023
Merged

feat: allow setting global quality defaults in config#884
danielroe merged 2 commits into
nuxt:mainfrom
Tragio:feat/global-quality

Conversation

@Tragio

@Tragio Tragio commented Jun 21, 2023

Copy link
Copy Markdown
Contributor

Hi there 👋

This PR allows setting the quality of the generated images in the module configuration.

Thank you very much for the amazing work 🚀

@ghost

ghost commented Jun 21, 2023

Copy link
Copy Markdown

Live Preview ready!

Name Edit Preview Latest Commit
Image Edit on Studio ↗︎ View Live Preview a0e9837

@netlify

netlify Bot commented Jun 21, 2023

Copy link
Copy Markdown

👷 Deploy request for nuxt-image pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit a0e9837

@codecov-commenter

codecov-commenter commented Jun 21, 2023

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.76%. Comparing base (919d9fd) to head (a0e9837).
⚠️ Report is 890 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #884      +/-   ##
==========================================
+ Coverage   89.71%   89.76%   +0.05%     
==========================================
  Files          43       43              
  Lines        2770     2775       +5     
  Branches      311      312       +1     
==========================================
+ Hits         2485     2491       +6     
+ Misses        284      283       -1     
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danielroe

Copy link
Copy Markdown
Member

You are a star - thank you ❤️

@danielroe
danielroe requested a review from hartmut-co-uk June 21, 2023 08:39

@hartmut-co-uk hartmut-co-uk left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
The solution should also apply quality at module config level to <nuxt-picture>, right?

Could you please also add tests to test/unit/picture.test.ts?

@Tragio

Tragio commented Jun 21, 2023

Copy link
Copy Markdown
Contributor Author

Great! The solution should also apply quality at module config level to <nuxt-picture>, right?

Could you please also add tests to test/unit/picture.test.ts?

Thank you very much 🙏 I only added one test, should I add all the tests that I did for nuxt-img? Just don't want to be redundant, since all is being passed to nuxt-picture. If you want I can do it without any problem 😄

@hartmut-co-uk

Copy link
Copy Markdown
Collaborator

Fair enough, I think this is good to go! 💪

@hartmut-co-uk
hartmut-co-uk requested a review from danielroe June 21, 2023 18:50
@danielroe
danielroe merged commit f5e2aa2 into nuxt:main Jun 21, 2023
@Tragio
Tragio deleted the feat/global-quality branch June 21, 2023 21:16
@danielroe danielroe mentioned this pull request Sep 13, 2023
@github-actions github-actions Bot mentioned this pull request Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants