Conversation
✅ Deploy Preview for nuxt-image-v1 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
danielroe
changed the title
ipx when node present
Merged
pi0
reviewed
Jun 6, 2023
Co-authored-by: pooya parsa <pooya@pi0.io>
pi0
changed the title
ipx when node presentnone provider and only enable ipx when node present
pi0
approved these changes
Jun 6, 2023
pi0
left a comment
pi0
left a comment
Member
There was a problem hiding this comment.
LGTM (thanks!).
About naming, i am thinking source or raw would be more suitable with upcoming unstorage related changes as it makes it a raw source provider (not a disabled situation or non-optimizer) but we can always keep alias and iterate.
Member
Author
|
Totally happy to rename before release and not keep alias - feel free to push change directly if you like 👍 |
This was referenced Jun 8, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.