Conversation
✅ Live Preview ready!
|
👷 Deploy request for nuxt-image pending review.Visit the deploys page to approve it
|
danielroe
changed the title
Member
|
Would you be able to add snapshots/expected values for prepr? 🙏 |
Contributor
Author
|
@danielroe Hey, I think anything is possible. Can you just clarity what you are looking for? Thanks |
Member
|
Merge in the latest changes in the main branch, and get the tests passing. (This requires adding |
Contributor
Author
|
Makes sense. Will do. :) |
Contributor
Author
|
@danielroe I think that's it :) |
danielroe
reviewed
Jun 7, 2023
danielroe
reviewed
Jun 7, 2023
danielroe
reviewed
Jun 7, 2023
danielroe
reviewed
Jun 7, 2023
danielroe
reviewed
Jun 7, 2023
danielroe
reviewed
Jun 7, 2023
Co-authored-by: Daniel Roe <daniel@roe.dev>
Co-authored-by: Daniel Roe <daniel@roe.dev>
danielroe
reviewed
Jun 7, 2023
danielroe
reviewed
Jun 7, 2023
Co-authored-by: Daniel Roe <daniel@roe.dev>
Co-authored-by: Daniel Roe <daniel@roe.dev>
Co-authored-by: Daniel Roe <daniel@roe.dev>
Co-authored-by: Daniel Roe <daniel@roe.dev>
danielroe
approved these changes
Jun 8, 2023
danielroe
left a comment
danielroe
left a comment
Member
There was a problem hiding this comment.
I think probably we could inline all the small helper files in the provider directory in a single file, but I'm not really sure it makes much difference.
Thank you for this - it'll be a great addition to the module!
danielroe
changed the title
prepr cms image provider integration
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an integration with Prepr Headless CMS, docs can be found at Prepr Docs.
Motivation and Context
While the image transformation options provided by this CMS are still few, their Support team informs me, that they are due to receive updates very soon. I also happen to need to use this provider on my personal project and I much prefer to share the provider with the community then have it all for myself. ❤️
Changes
BuiltInProvidersarray alphabetically, no removals were made, onlypreprkey was added.src/runtime/preprfolder containing the necessary code, togetImage.docs/contentplayground