Skip to content

fix: use absolute path for prerenderer - #788

Merged
danielroe merged 2 commits into
mainfrom
fix/prerenderer-images
Mar 30, 2023
Merged

fix: use absolute path for prerenderer#788
danielroe merged 2 commits into
mainfrom
fix/prerenderer-images

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

#780 (comment)

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Ugh. Apologies for the iteration on this one. I think we'll need to use an absolute path for the prerenderer, and relative for the built version.

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working ipx labels Mar 29, 2023
@danielroe
danielroe requested a review from pi0 March 29, 2023 19:07
@danielroe danielroe self-assigned this Mar 29, 2023
@codesandbox

codesandbox Bot commented Mar 29, 2023

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlify Bot commented Mar 29, 2023

Copy link
Copy Markdown

Deploy Preview for nuxt-image-v1 canceled.

Name Link
🔨 Latest commit 97d746d
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-image-v1/deploys/64248c73bdc7410008f60802

@pi0 pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if already tested 💯

@danielroe
danielroe merged commit c6a7c9b into main Mar 30, 2023
@danielroe
danielroe deleted the fix/prerenderer-images branch March 30, 2023 09:57
@pi0 pi0 mentioned this pull request Mar 31, 2023
@github-actions github-actions Bot mentioned this pull request Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ipx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants