Skip to content

fix(ipx): set prerenderer config as well - #784

Merged
pi0 merged 3 commits into
mainfrom
fix/prerenderer-config
Mar 29, 2023
Merged

fix(ipx): set prerenderer config as well#784
pi0 merged 3 commits into
mainfrom
fix/prerenderer-config

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolves #780

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

The Nitro prerenderer does not share the same runtimeConfig instance so we can set it on _config.

Opening the PR as hotfix but we may also want to change behaviour in nitro or provide a hook to allow us to configure the prerenderer more specifically (even just another call of nitro:config would be ideal).

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added the bug Something isn't working label Mar 28, 2023
@danielroe
danielroe requested a review from pi0 March 28, 2023 18:39
@danielroe danielroe self-assigned this Mar 28, 2023
@codesandbox

codesandbox Bot commented Mar 28, 2023

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlify Bot commented Mar 28, 2023

Copy link
Copy Markdown

Deploy Preview for nuxt-image-v1 canceled.

Name Link
🔨 Latest commit a92f48e
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-image-v1/deploys/64241277d4ba2b0007d6ad6f

@pi0

pi0 commented Mar 29, 2023

Copy link
Copy Markdown
Member

Calling nitro:config for proper fix seems good idea 👍🏼

Comment thread src/ipx.ts
@pi0 pi0 changed the title fix: set prerenderer config as well fix(ipx): set prerenderer config as well Mar 29, 2023
@pi0
pi0 merged commit 0aa03b6 into main Mar 29, 2023
@pi0 pi0 mentioned this pull request Mar 31, 2023
@ibrahim-990

Copy link
Copy Markdown

To fix this ERROR [nuxt] [request error] [unhandled] [500] The URL must be of scheme file.
on npm run generate.
I need to add the file (ipx.ts) ?
@pi0

@danielroe
danielroe deleted the fix/prerenderer-config branch August 27, 2024 09:16
@github-actions github-actions Bot mentioned this pull request Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ERROR [nuxt] [request error] [unhandled] [500] Cannot read properties of undefined (reading 'dir')

3 participants