Skip to content

fix(ipx): use actual relative ipx dir - #779

Merged
pi0 merged 1 commit into
mainfrom
fix/custom-public-ipx
Mar 22, 2023
Merged

fix(ipx): use actual relative ipx dir#779
pi0 merged 1 commit into
mainfrom
fix/custom-public-ipx

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

resolves #749
resolves #758

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

This removes hardcoded relative paths for the public dir. In so doing it fixes a couple of bugs with netlify, but also for any other preset which didn't output to ../public (next to a server directory).

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@danielroe danielroe added bug Something isn't working ipx labels Mar 21, 2023
@danielroe
danielroe requested a review from pi0 March 21, 2023 17:01
@danielroe danielroe self-assigned this Mar 21, 2023
@codesandbox

codesandbox Bot commented Mar 21, 2023

Copy link
Copy Markdown

CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders

@netlify

netlify Bot commented Mar 21, 2023

Copy link
Copy Markdown

Deploy Preview for nuxt-image-v1 canceled.

Name Link
🔨 Latest commit 2e5f46a
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-image-v1/deploys/6419e2ce74fa8f00081a1793

Comment thread src/ipx.ts
@pi0
pi0 merged commit 2b960c4 into main Mar 22, 2023
@danielroe
danielroe deleted the fix/custom-public-ipx branch March 22, 2023 13:39
@pi0 pi0 mentioned this pull request Mar 31, 2023
@github-actions github-actions Bot mentioned this pull request Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ipx

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Module does not work with Netlify Netlify setup not working

2 participants