Skip to content

feat: add wagtail provider - #774

Merged
danielroe merged 8 commits into
nuxt:mainfrom
bonomite:bonomite/wagtail-provider
Jun 6, 2023
Merged

feat: add wagtail provider#774
danielroe merged 8 commits into
nuxt:mainfrom
bonomite:bonomite/wagtail-provider

Conversation

@bonomite

Copy link
Copy Markdown
Contributor

I created a provider to support the URL structure for the Wagtail CMS image template (https://docs.wagtail.org/en/v4.2.1/topics/images.html)

I think I got everything set up correctly. Thanks

@netlify

netlify Bot commented Mar 19, 2023

Copy link
Copy Markdown

Deploy Preview for nuxt-image-v1 ready!

Name Link
🔨 Latest commit feb6294
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-image-v1/deploys/647f38b11c20a30008242e9f
😎 Deploy Preview https://deploy-preview-774--nuxt-image-v1.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pi0 pi0 changed the title Bonomite/wagtail provider feat: add wagtail provider Mar 31, 2023
@pi0 pi0 added enhancement New feature or request provider labels Mar 31, 2023
@danielroe

Copy link
Copy Markdown
Member

Would you be able to merge the latest main and add snapshots/expected values for wagtail? 🙏

@ghost

ghost commented May 30, 2023

Copy link
Copy Markdown

Live Preview ready!

Name Edit Preview Latest Commit
Image Edit on Studio ↗︎ View Live Preview feb6294

@bonomite

Copy link
Copy Markdown
Contributor Author

@danielroe, I think we are good. Except it looks like the IPX provider test is failing
image

I'm pretty sure I had nothing to do with it. I hope.

@danielroe

Copy link
Copy Markdown
Member

@bonomite That seems like an unrelated issue, for sure, but worth investigating.

@danielroe
danielroe requested a review from pi0 May 30, 2023 19:02
@bonomite

Copy link
Copy Markdown
Contributor Author

Thanks! Sorry about the typo 😬

@pi0 pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't locally tested but looks 💯

@danielroe
danielroe merged commit 1304e30 into nuxt:main Jun 6, 2023
@pi0 pi0 mentioned this pull request Jun 6, 2023
@github-actions github-actions Bot mentioned this pull request Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants