fix: remove key for picture/image to stop flicker when loading - #760
Merged
Conversation
…mainSrc Set `key` via `props.src` instead of the computed `src` which leads to redraw of the img element upon replacement of the placeholder with the main image.
✅ Deploy Preview for nuxt-image ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
pi0
changed the title
mainSrc
danielroe
reviewed
Jun 7, 2023
Member
There was a problem hiding this comment.
This looks good to me - though I'm not sure why there is a key indeed.
I would suggest we remove it from here and <nuxt-picture> unless @pi0 thinks it is still required. (It was originally introduced in the Vue 2 version of this module.)
danielroe
changed the title
mainSrckey for picture/image to stop flicker when loading
danielroe
approved these changes
Jun 10, 2023
atinux
approved these changes
Jun 12, 2023
atinux
left a comment
atinux
left a comment
Member
There was a problem hiding this comment.
We will see if we need to add it back later but sounds good to me
Merged
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detailed description / discussion on #759
Set
keyviaprops.srcinstead of the computedsrcwhich leads to redraw of the img element upon replacement of the placeholder with the main image.