Skip to content

feat: add uploadcare provider - #740

Merged
danielroe merged 16 commits into
nuxt:mainfrom
luc122c:main
Jun 22, 2023
Merged

feat: add uploadcare provider#740
danielroe merged 16 commits into
nuxt:mainfrom
luc122c:main

Conversation

@luc122c

@luc122c luc122c commented Feb 7, 2023

Copy link
Copy Markdown
Contributor

This PR resolves #513 by implementing a new built-in provider for uploadcare.

Operations

  • Image Compression
  • Image Geometry
  • Image Overlays
  • Image Colours
  • Image Definition
  • Image Rotations

Other stuff to think about later:

@netlify

netlify Bot commented Feb 7, 2023

Copy link
Copy Markdown

Deploy Preview for nuxt-image ready!

Name Link
🔨 Latest commit 043c472
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-image/deploys/64944c69fb1f5f00087c4908
😎 Deploy Preview https://deploy-preview-740--nuxt-image.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@luc122c

luc122c commented Feb 7, 2023

Copy link
Copy Markdown
Contributor Author

Hi maintainers. I'm not sure if I've done this exactly right so I'd be gradeful for any tips/advice. I've tried to follow other providers as closely as I can. 👍

@pi0 pi0 changed the title feat: New provider: Uploadcare feat: add uploadcare provider Mar 31, 2023
@pi0 pi0 added enhancement New feature or request provider labels Mar 31, 2023
@danielroe

Copy link
Copy Markdown
Member

Would you be able to merge the latest main and add snapshots/expected values? 🙏

@luc122c

luc122c commented Jun 12, 2023

Copy link
Copy Markdown
Contributor Author

Would you be able to merge the latest main and add snapshots/expected values? 🙏

I can certainly try. Please could you link to a good example of how you'd like it?

@danielroe

Copy link
Copy Markdown
Member

Here's an example recent PR that included tests: https://github.com/nuxt/image/pull/774/files.

@luc122c

luc122c commented Jun 12, 2023

Copy link
Copy Markdown
Contributor Author

Thanks! I'll give it a go :)

@luc122c
luc122c marked this pull request as ready for review June 21, 2023 09:58
@luc122c

luc122c commented Jun 21, 2023

Copy link
Copy Markdown
Contributor Author

@danielroe The tests are now passing, I hope I've done them correctly.
This provider is in a suitable state to be used, I just haven't added some of the more advanced features yet. Would you like to merge it as-is and I can work on the other providers in a follow-up PR?

@danielroe

Copy link
Copy Markdown
Member

Fantastic! Would you be able to add a page to the documentation? 🙏

You could also include a note about what's usable, and maybe point people to make a PR if they would like.

@codecov-commenter

codecov-commenter commented Jun 21, 2023

Copy link
Copy Markdown

Codecov Report

Patch coverage: 93.54% and project coverage change: +0.08 🎉

Comparison is base (4865ccb) 89.76% compared to head (043c472) 89.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #740      +/-   ##
==========================================
+ Coverage   89.76%   89.85%   +0.08%     
==========================================
  Files          43       44       +1     
  Lines        2776     2869      +93     
  Branches      312      319       +7     
==========================================
+ Hits         2492     2578      +86     
- Misses        283      290       +7     
  Partials        1        1              
Impacted Files Coverage Δ
src/runtime/providers/uploadcare.ts 91.17% <91.17%> (ø)
src/provider.ts 95.83% <100.00%> (-0.81%) ⬇️
src/types/module.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ghost

ghost commented Jun 22, 2023

Copy link
Copy Markdown

Live Preview ready!

Name Edit Preview Latest Commit
Image Edit on Studio ↗︎ View Live Preview 043c472

@luc122c

luc122c commented Jun 22, 2023

Copy link
Copy Markdown
Contributor Author

@danielroe I've added some documentation, I hope it's OK! Please let me know if you have any additional feeback.

Comment thread docs/content/5.providers/uploadcare.md Outdated

@danielroe danielroe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me! Thank you for your work on this ❤️

@luc122c

luc122c commented Jun 22, 2023

Copy link
Copy Markdown
Contributor Author

No problem. Many thanks to you and the the other maintainers for a great module!

@danielroe
danielroe merged commit 955386a into nuxt:main Jun 22, 2023
@danielroe danielroe mentioned this pull request Sep 13, 2023
@github-actions github-actions Bot mentioned this pull request Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

adding support for uploadcare provider

4 participants