Conversation
✅ Deploy Preview for nuxt-image ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hi maintainers. I'm not sure if I've done this exactly right so I'd be gradeful for any tips/advice. I've tried to follow other providers as closely as I can. 👍 |
|
Would you be able to merge the latest main and add snapshots/expected values? 🙏 |
I can certainly try. Please could you link to a good example of how you'd like it? |
|
Here's an example recent PR that included tests: https://github.com/nuxt/image/pull/774/files. |
|
Thanks! I'll give it a go :) |
|
@danielroe The tests are now passing, I hope I've done them correctly. |
|
Fantastic! Would you be able to add a page to the documentation? 🙏 You could also include a note about what's usable, and maybe point people to make a PR if they would like. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #740 +/- ##
==========================================
+ Coverage 89.76% 89.85% +0.08%
==========================================
Files 43 44 +1
Lines 2776 2869 +93
Branches 312 319 +7
==========================================
+ Hits 2492 2578 +86
- Misses 283 290 +7
Partials 1 1
☔ View full report in Codecov by Sentry. |
✅ Live Preview ready!
|
|
@danielroe I've added some documentation, I hope it's OK! Please let me know if you have any additional feeback. |
danielroe
left a comment
There was a problem hiding this comment.
Looks great to me! Thank you for your work on this ❤️
|
No problem. Many thanks to you and the the other maintainers for a great module! |
This PR resolves #513 by implementing a new built-in provider for uploadcare.
Operations
Other stuff to think about later: