Skip to content

fix!: improve prerendering support - #725

Merged
pi0 merged 3 commits into
mainfrom
fix/ipx-url-encoding
Jan 27, 2023
Merged

fix!: improve prerendering support#725
pi0 merged 3 commits into
mainfrom
fix/ipx-url-encoding

Conversation

@pi0

@pi0 pi0 commented Jan 27, 2023

Copy link
Copy Markdown
Member

Fixes various issues related to static image prerendering.

close #701 (thanks @posixpascal) close #674 (thanks @jimhlad)

should generally resolve issues in #671 and #689

Changes:

  • Use a new internal util prerenderStaticImages
    • Properly split with , (instead of ,)
    • Encode each path before pushing to header (requires Nitro 2 / Nuxt 3.1)
    • Avoid adding empty headers
  • Support prerendering for nuxt-picture as well
  • Use & as modifier splitter in ipx provider links in order to support windows paths.

@netlify

netlify Bot commented Jan 27, 2023

Copy link
Copy Markdown

Deploy Preview for nuxt-image-v1 canceled.

Name Link
🔨 Latest commit 8ff4f00
🔍 Latest deploy log https://app.netlify.com/sites/nuxt-image-v1/deploys/63d3bc6c75e24c0009cf60a1

@pi0 pi0 changed the title fix: improve prerendering support fix!: improve prerendering support Jan 27, 2023
@pi0
pi0 merged commit 96fd3d0 into main Jan 27, 2023
@pi0
pi0 deleted the fix/ipx-url-encoding branch January 27, 2023 12:01
procrates pushed a commit to procrates/nuxt-image that referenced this pull request Feb 21, 2023
Co-Authored-By: Pascal <posixpascal@googlemail.com>
Co-Authored-By:  Jim Hlad <jimhlad@gmail.com>
@pi0 pi0 mentioned this pull request Mar 31, 2023
@github-actions github-actions Bot mentioned this pull request Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant