Skip to content

fix(nuxt-picture): only pass defined props to <nuxt-img> component - #620

Merged
pi0 merged 5 commits into
nuxt:mainfrom
nthduy:fix/608-picture-prop-override
Nov 24, 2022
Merged

fix(nuxt-picture): only pass defined props to <nuxt-img> component#620
pi0 merged 5 commits into
nuxt:mainfrom
nthduy:fix/608-picture-prop-override

Conversation

@nthduy

@nthduy nthduy commented Sep 21, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

@netlify

netlify Bot commented Sep 21, 2022

Copy link
Copy Markdown

👷 Deploy request for nuxt-image-v1 pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit edea75a

hartmut-co-uk
hartmut-co-uk approved these changes Nov 12, 2022
View reviewed changes

@hartmut-co-uk hartmut-co-uk left a comment •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
One question comes to mind though - is it correct that baseImageProps does not have class prop?
And/or is it going to stay like this?
Maybe it would be safer to explicitly avoid class from being passed down?

@pi0 pi0 changed the title fix(image): Pass only defined props to img tag fix(nuxt-picture): only pass defined props to <nuxt-img> component Nov 24, 2022
pi0
pi0 approved these changes Nov 24, 2022
View reviewed changes

@pi0 pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️

@pi0
pi0 merged commit 522ffa2 into nuxt:main Nov 24, 2022
@nthduy
nthduy deleted the fix/608-picture-prop-override branch December 15, 2022 14:59
procrates pushed a commit to procrates/nuxt-image that referenced this pull request Feb 21, 2023
@nthduy @pi0
fix(nuxt-picture): only pass defined props to <nuxt-img> component (n…
2613e29 
…uxt#620)

Co-authored-by: Pooya Parsa <pooya@pi0.io>
@pi0 pi0 mentioned this pull request Mar 31, 2023
Merged
@github-actions github-actions Bot mentioned this pull request Jul 30, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pi0 pi0 pi0 approved these changes
@hartmut-co-uk hartmut-co-uk hartmut-co-uk approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Nuxt Picture class prop override Nuxt Image

3 participants

@nthduy @pi0 @hartmut-co-uk