Skip to content

feat(twicpics): fix modifiers and improve documentation - #503

Merged
pi0 merged 5 commits into
nuxt:mainfrom
mbgspcii:features/twicpics_additionnal_documentation
Jun 21, 2022
Merged

feat(twicpics): fix modifiers and improve documentation#503
pi0 merged 5 commits into
nuxt:mainfrom
mbgspcii:features/twicpics_additionnal_documentation

Conversation

@mbgspcii

@mbgspcii mbgspcii commented Apr 5, 2022

Copy link
Copy Markdown
Contributor

TwicPics provider:

  • fixes fit=contain feature
  • fixes fit=inside feature
  • fixes fit=outside feature
  • additional documentation and playground samples

@mbgspcii mbgspcii changed the title Features/twicpics additionnal documentation feat(provider): twicpics - additionnal documentation Apr 5, 2022
Comment thread docs/content/en/4.providers/twicpics.md Outdated
Comment thread docs/content/en/4.providers/twicpics.md Outdated
Comment thread docs/content/en/4.providers/twicpics.md Outdated
Comment thread docs/content/en/4.providers/twicpics.md Outdated

@atinux atinux left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments, thank you for this PR ❤️

@mbgspcii
mbgspcii force-pushed the features/twicpics_additionnal_documentation branch from a07b555 to 81ec25e Compare April 6, 2022 12:41
@mbgspcii
mbgspcii requested a review from atinux April 10, 2022 09:30
@mbgspcii
mbgspcii force-pushed the features/twicpics_additionnal_documentation branch from 81ec25e to 77232da Compare April 15, 2022 08:10
@pi0 pi0 changed the title feat(provider): twicpics - additionnal documentation feat(twicpics ): fix modifiers and improve documentation Jun 20, 2022
@pi0 pi0 changed the title feat(twicpics ): fix modifiers and improve documentation feat(twicpics): fix modifiers and improve documentation Jun 20, 2022
@pi0

pi0 commented Jun 21, 2022

Copy link
Copy Markdown
Member

Thanks @mbgspcii @atinux for working on this 💯

@pi0
pi0 merged commit 7942232 into nuxt:main Jun 21, 2022
pi0 added a commit that referenced this pull request Jun 21, 2022
procrates pushed a commit to procrates/nuxt-image that referenced this pull request Feb 21, 2023
Co-authored-by: Miguel Beignon <miguel@twic.pics>
procrates pushed a commit to procrates/nuxt-image that referenced this pull request Feb 21, 2023
@github-actions github-actions Bot mentioned this pull request Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants