Skip to content

fix(ipx): allow overriding baseURL regardless of router base - #484

Merged
pi0 merged 4 commits into
nuxt:mainfrom
jeanmatthieud:external-ipx
Jun 21, 2022
Merged

fix(ipx): allow overriding baseURL regardless of router base#484
pi0 merged 4 commits into
nuxt:mainfrom
jeanmatthieud:external-ipx

Conversation

@jeanmatthieud

@jeanmatthieud jeanmatthieud commented Feb 4, 2022

Copy link
Copy Markdown
Contributor

#483

Removing this non existing context variable use allows the proper configuration of the baseURL variable, and, at the same time, the use of an external IPX server.

@pi0 pi0 changed the title [FIX] Not existing context variable use removed #483 fix: remove not existing context variable Jun 20, 2022
@pi0 pi0 changed the title fix: remove not existing context variable fix(ipx): allow overriding baseURL regardless of router base Jun 21, 2022
@pi0

pi0 commented Jun 21, 2022

Copy link
Copy Markdown
Member

Thanks. I've fixed types and made modification to still be able completely override baseURL still respect router base when generating default _ipx endpoint.

@pi0
pi0 merged commit 2720956 into nuxt:main Jun 21, 2022
@jeanmatthieud
jeanmatthieud deleted the external-ipx branch June 21, 2022 15:33
procrates pushed a commit to procrates/nuxt-image that referenced this pull request Feb 21, 2023
)

Co-authored-by: Pooya Parsa <pyapar@gmail.com>
@chrisspiegl

Copy link
Copy Markdown
Contributor

I just tried this out and first thought I could not use baseURL with the IPX and thus use an external IPX server because the baseURL seems to not be included in the typescript type of IPXOptions?

Xnapper-2023-02-28-18 54 27

@github-actions github-actions Bot mentioned this pull request Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants