Skip to content

feat: strapi provider - #406

Merged
pi0 merged 12 commits into
nuxt:mainfrom
roberthgnz:main
Feb 17, 2022
Merged

feat: strapi provider#406
pi0 merged 12 commits into
nuxt:mainfrom
roberthgnz:main

Conversation

@roberthgnz

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread src/runtime/providers/strapi.ts Outdated
Comment thread src/runtime/providers/strapi.ts Outdated
@pi0

pi0 commented Oct 8, 2021

Copy link
Copy Markdown
Member

Hi @eliutgon and thanks for the feature! Do you mind adding basic docs to providers and also mention about only breakpoint modifier is possible?

@roberthgnz

Copy link
Copy Markdown
Contributor Author

Hi @eliutgon and thanks for the feature! Do you mind adding basic docs to providers and also mention about only breakpoint modifier is possible?

Hi. sure, I will get on it.

Comment thread src/runtime/providers/strapi.ts Outdated
Comment thread docs/content/en/4.providers/strapi.md Outdated
@pi0 pi0 changed the title feat: allow strapi uploads using the local provider feat: strapi provider Jan 13, 2022
@pi0 pi0 added the provider label Jan 13, 2022
@pi0

pi0 commented Feb 17, 2022

Copy link
Copy Markdown
Member

Sorry for the late merge. Implementation seems nice but strapi provider is different from others as it does not actually provide any means to resize or optimize images. Let's have it as is for now!

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #406 (95b759c) into main (61bcb90) will decrease coverage by 59.11%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #406       +/-   ##
==========================================
- Coverage   59.11%   0.00%   -59.12%     
==========================================
  Files          29      28        -1     
  Lines         658     587       -71     
  Branches      208     188       -20     
==========================================
- Hits          389       0      -389     
- Misses        263     585      +322     
+ Partials        6       2        -4     
Impacted Files Coverage Δ
src/provider.ts 0.00% <ø> (-74.29%) ⬇️
src/runtime/providers/strapi.ts 0.00% <0.00%> (ø)
src/runtime/providers/ipx.ts 0.00% <0.00%> (-100.00%) ⬇️
src/runtime/providers/glide.ts 0.00% <0.00%> (-100.00%) ⬇️
src/runtime/providers/imgix.ts 0.00% <0.00%> (-100.00%) ⬇️
src/runtime/providers/fastly.ts 0.00% <0.00%> (-100.00%) ⬇️
src/runtime/providers/static.ts 0.00% <0.00%> (-100.00%) ⬇️
src/runtime/providers/unsplash.ts 0.00% <0.00%> (-100.00%) ⬇️
src/runtime/providers/contentful.ts 0.00% <0.00%> (-100.00%) ⬇️
src/runtime/providers/imageengine.ts 0.00% <0.00%> (-100.00%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61bcb90...95b759c. Read the comment docs.

@pi0
pi0 merged commit 8245c22 into nuxt:main Feb 17, 2022
procrates pushed a commit to procrates/nuxt-image that referenced this pull request Feb 21, 2023
@github-actions github-actions Bot mentioned this pull request Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants