fix: pass domains to runtime options - #333
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #333 +/- ##
===========================================
- Coverage 59.50% 14.25% -45.25%
===========================================
Files 26 24 -2
Lines 600 533 -67
Branches 150 136 -14
===========================================
- Hits 357 76 -281
- Misses 243 457 +214
Continue to review full report at Codecov.
|
Member
|
Multi-provider purpose is to allow transparently switching between them (they can yet normalize to what they expect like trimming to hostname only) For domain is there any special reason to make it vendor-specific? Why is important? By ensuring there is one source of trust of allowed domains, we can also warn users in runtime (without provider level check) domain is not included or automatically externalize. |
domains to runtime options
pi0
approved these changes
Jun 23, 2021
procrates
pushed a commit
to procrates/nuxt-image
that referenced
this pull request
Feb 21, 2023
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This no longer treats
staticas unique and moves domains to the global context.closes #324