Skip to content

feat: glide provider - #328

Merged
pi0 merged 9 commits into
nuxt:mainfrom
shadow81627:feat/provider/glide
Jun 22, 2021
Merged

feat: glide provider#328
pi0 merged 9 commits into
nuxt:mainfrom
shadow81627:feat/provider/glide

Conversation

@shadow81627

@shadow81627 shadow81627 commented Jun 18, 2021

Copy link
Copy Markdown
Contributor

@codecov-commenter

codecov-commenter commented Jun 18, 2021

Copy link
Copy Markdown

Codecov Report

Merging #328 (7cd8007) into main (ef52af9) will decrease coverage by 44.64%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #328       +/-   ##
===========================================
- Coverage   59.09%   14.44%   -44.65%     
===========================================
  Files          25       24        -1     
  Lines         594      533       -61     
  Branches      178      135       -43     
===========================================
- Hits          351       77      -274     
- Misses        243      456      +213     
Impacted Files Coverage Δ
src/provider.ts 61.11% <ø> (-11.12%) ⬇️
src/runtime/providers/glide.ts 0.00% <0.00%> (ø)
src/runtime/providers/imgix.ts 0.00% <0.00%> (-100.00%) ⬇️
src/runtime/providers/fastly.ts 0.00% <0.00%> (-100.00%) ⬇️
src/runtime/providers/static.ts 0.00% <0.00%> (-100.00%) ⬇️
src/runtime/providers/prismic.ts 0.00% <0.00%> (-85.72%) ⬇️
src/runtime/providers/ipx.ts 0.00% <0.00%> (-84.62%) ⬇️
src/runtime/components/image.mixin.ts 0.00% <0.00%> (-81.82%) ⬇️
src/runtime/providers/cloudinary.ts 0.00% <0.00%> (-80.96%) ⬇️
src/runtime/providers/netlify.ts 0.00% <0.00%> (-77.78%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef52af9...7cd8007. Read the comment docs.

Comment thread src/runtime/providers/glide.ts Outdated
@pi0

pi0 commented Jun 18, 2021

Copy link
Copy Markdown
Member

Thanks 🙌 Would you mind also updating playground and docs to add new provider?

@shadow81627

Copy link
Copy Markdown
Contributor Author

@pi0

The only glide instance that I have hosted is the one I use at work... not sure if they would be super happy having it in examples. Do you have any suggestions for the best way to provide a glide instance? Maybe I can host one on Heroku?

@shadow81627
shadow81627 requested a review from pi0 June 19, 2021 01:57
@pi0

pi0 commented Jun 21, 2021

Copy link
Copy Markdown
Member

We usually use examples in provider documentation. For glide i could find this:

https://glide.herokuapp.com/1.0/kayaks.jpg?w=1000&gam=.9&sharp=8

@pi0 pi0 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat 👍

}
})

test('glide', () => {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/refactor note: We may auto generate tests with a loop (/cc @danielroe)

@pi0 pi0 changed the title feat(provider): glide feat: glide provider Jun 22, 2021
@pi0
pi0 merged commit 1d85042 into nuxt:main Jun 22, 2021
procrates pushed a commit to procrates/nuxt-image that referenced this pull request Feb 21, 2023
@github-actions github-actions Bot mentioned this pull request Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Glide image provider

3 participants