Skip to content

fix(directus): remove deprecated sharpen option - #2294

Merged
danielroe merged 2 commits into
nuxt:mainfrom
kheiner:fix/directus-sharpen-shape
Jul 29, 2026
Merged

fix(directus): remove deprecated sharpen option#2294
danielroe merged 2 commits into
nuxt:mainfrom
kheiner:fix/directus-sharpen-shape

Conversation

@kheiner

@kheiner kheiner commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

directus/directus#27990 bumps from Sharp 0.34.5 to 0.35.3

🔗 Linked issue

resolves #2293

📚 Description

updated sharp operation to match v0.35 shape.

The currently released version of nuxt/image is fully functional for Directus <12.1.1 ; no rush no merging the fix.

@kheiner
kheiner requested a review from danielroe as a code owner July 29, 2026 03:01
@pkg-pr-new

pkg-pr-new Bot commented Jul 29, 2026

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@nuxt/image@2294

commit: db923dc

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The Directus provider’s Sharp operation map now restricts the sharpen modifier to an options object containing the supported sharpening parameters, and the documentation reflects this signature while removing the sigma-only tuple form.

Estimated code review effort: 1 (Trivial) | ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly matches the main change: removing the deprecated Directus sharpen option.
Description check ✅ Passed The description is on-topic and accurately describes the Sharp v0.35 Directus update.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

codecov-commenter commented Jul 29, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.61%. Comparing base (05758b6) to head (db923dc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2294   +/-   ##
=======================================
  Coverage   32.61%   32.61%           
=======================================
  Files           7        7           
  Lines         371      371           
  Branches      131      131           
=======================================
  Hits          121      121           
  Misses        194      194           
  Partials       56       56           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kheiner

kheiner commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

Failing tests are not related to my changes (alyun is not rendering images)

@danielroe
danielroe added this pull request to the merge queue Jul 29, 2026
Merged via the queue into nuxt:main with commit f09eef6 Jul 29, 2026
14 of 17 checks passed
This was referenced Jul 29, 2026
@kheiner
kheiner deleted the fix/directus-sharpen-shape branch July 30, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Directus is bumping its sharp dependency from 0.34.5 to 0.35.3

3 participants