ci: improve workflows - #2288
Conversation
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2288 +/- ##
=======================================
Coverage 32.61% 32.61%
=======================================
Files 7 7
Lines 371 371
Branches 131 131
=======================================
Hits 121 121
Misses 194 194
Partials 56 56 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This reverts commit 64703da.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughGitHub Actions workflows now define concurrency behavior for CI and nightly releases. Checkout steps disable persisted credentials, the lint job uses the Node.js 24 release line, and selected jobs run on Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/ci.yml:
- Around line 55-56: Update the actions/checkout step in the changes job to set
persist-credentials to false, matching the hardened checkout configuration used
elsewhere in the workflow.
In @.github/workflows/release-nightly.yml:
- Around line 13-15: Update the workflow’s concurrency configuration to set the
pending-run queue behavior to max, preserving cancel-in-progress: false, so all
nightly release events are retained and processed sequentially in FIFO order.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 0eb1dd76-1901-44b3-9d51-339741b76c84
📒 Files selected for processing (4)
.github/workflows/agent-scan.yml.github/workflows/ci.yml.github/workflows/release-nightly.yml.github/workflows/reproduction-close.yml
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
🔗 Linked issue
📚 Description
Hi, there are a few improvements that can be made to the workflows.
ubuntu-slimrunnerUse
ubuntu-slimforagent-scan.yml,reproduction.-close.ymland some inci.yml. The runner readme provides more info about the tools and the blog post gives some potential use cases.persist-credentials: falseUse
persist-credentials: falseon everyactions/checkoutinci.yml(none of the jobs perform subsequent git operations). See usage for more info.Concurrency
Add
concurrencyto the PR-triggered workflows so a new push cancels the previous in-flight run of the same workflow.release-nightly.ymluses thecancel-in-progress: falseas to not interrupt the release. Instead, it will queue the next release.Related