feat: support domains option with Netlify Image CDN - #1287
Merged
Conversation
✅ Live Preview ready!
|
8 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1287 +/- ##
==========================================
- Coverage 68.20% 66.96% -1.24%
==========================================
Files 76 79 +3
Lines 4299 4501 +202
Branches 397 404 +7
==========================================
+ Hits 2932 3014 +82
- Misses 1339 1458 +119
- Partials 28 29 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
danielroe
approved these changes
Mar 17, 2024
danielroe
left a comment
Member
There was a problem hiding this comment.
Looks good to me. Just waiting for Nitro PR to merge.
Contributor
Author
|
@danielroe the Nitro PR is now in! |
Member
|
Fantastic! I’ll just confirm that domains are always normalised to without protocol and then we should be good to go… |
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for configuring remote images in Netlify Image CDN. Previously this required manual configuration in the
netlify.toml. With this PR, the provider sets the value automatically based on theimage.domainsoption.Depends on nitrojs/nitro#2264