Skip to content

feat: support domains option with Netlify Image CDN - #1287

Merged
danielroe merged 2 commits into
nuxt:mainfrom
ascorbic:netlify-remote-images
Mar 27, 2024
Merged

feat: support domains option with Netlify Image CDN#1287
danielroe merged 2 commits into
nuxt:mainfrom
ascorbic:netlify-remote-images

Conversation

@ascorbic

Copy link
Copy Markdown
Contributor

Adds support for configuring remote images in Netlify Image CDN. Previously this required manual configuration in the netlify.toml. With this PR, the provider sets the value automatically based on the image.domains option.

Depends on nitrojs/nitro#2264

@ghost

ghost commented Mar 15, 2024

Copy link
Copy Markdown

Live Preview ready!

Name Edit Preview Latest Commit
Image Edit on Studio ↗︎ View Live Preview 97f96d6

@codecov-commenter

codecov-commenter commented Mar 15, 2024

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.96%. Comparing base (8701991) to head (8907444).
⚠️ Report is 663 commits behind head on main.

Files with missing lines Patch % Lines
src/provider.ts 66.66% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1287      +/-   ##
==========================================
- Coverage   68.20%   66.96%   -1.24%     
==========================================
  Files          76       79       +3     
  Lines        4299     4501     +202     
  Branches      397      404       +7     
==========================================
+ Hits         2932     3014      +82     
- Misses       1339     1458     +119     
- Partials       28       29       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@danielroe danielroe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just waiting for Nitro PR to merge.

@ascorbic

Copy link
Copy Markdown
Contributor Author

@danielroe the Nitro PR is now in!

@danielroe

Copy link
Copy Markdown
Member

Fantastic! I’ll just confirm that domains are always normalised to without protocol and then we should be good to go…

@danielroe
danielroe merged commit b3bde17 into nuxt:main Mar 27, 2024
@github-actions github-actions Bot mentioned this pull request Mar 27, 2024
@github-actions github-actions Bot mentioned this pull request Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants