Skip to content

chore: add types to ipx provider options - #1132

Merged
danielroe merged 5 commits into
nuxt:mainfrom
aaharu:re-ipx-providers-options
Dec 13, 2023
Merged

chore: add types to ipx provider options#1132
danielroe merged 5 commits into
nuxt:mainfrom
aaharu:re-ipx-providers-options

Conversation

@aaharu

@aaharu aaharu commented Nov 29, 2023

Copy link
Copy Markdown
Contributor

rework of #976

https://image.nuxt.com/get-started/configuration#modifiers
According to the document, setting to default modifiers should be possible, but it wasn't working in typescript, so I fixed it.

@aaharu aaharu mentioned this pull request Nov 29, 2023
@atinux atinux changed the title fix ipx provider options chore: add types to ipx provider options Dec 12, 2023
@atinux
atinux requested a review from pi0 December 12, 2023 18:04
Comment thread src/types/module.ts Outdated
animated: true | 'true'
}

export interface StaticIPXOptions extends Omit<IPXRuntimeConfig, 'alias'> {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since after refactors i guess simply call interface IPXOtions..

Comment thread src/types/module.ts
Comment thread src/types/module.ts Outdated
Comment thread src/types/module.ts Outdated
@codecov-commenter

codecov-commenter commented Dec 12, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (d81e8fb) 70.47% compared to head (27b82e5) 70.75%.
Report is 1 commits behind head on main.

Files Patch % Lines
src/module.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1132      +/-   ##
==========================================
+ Coverage   70.47%   70.75%   +0.27%     
==========================================
  Files          71       71              
  Lines        4030     4065      +35     
  Branches      383      384       +1     
==========================================
+ Hits         2840     2876      +36     
  Misses       1165     1165              
+ Partials       25       24       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread src/types/module.ts
@danielroe
danielroe merged commit 2dee537 into nuxt:main Dec 13, 2023
@aaharu
aaharu deleted the re-ipx-providers-options branch February 20, 2024 08:26
riddla pushed a commit to tricks-gmbh/nuxt-image that referenced this pull request Mar 1, 2024
@github-actions github-actions Bot mentioned this pull request Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants