Skip to content

feat: add sirv provider - #1066

Merged
danielroe merged 2 commits into
nuxt:mainfrom
IgorVaryvoda:main
Oct 22, 2023
Merged

feat: add sirv provider#1066
danielroe merged 2 commits into
nuxt:mainfrom
IgorVaryvoda:main

Conversation

@IgorVaryvoda

@IgorVaryvoda IgorVaryvoda commented Oct 20, 2023

Copy link
Copy Markdown
Contributor

This PR adds support for Sirv image provider

@ghost

ghost commented Oct 20, 2023

Copy link
Copy Markdown

Live Preview ready!

Name Edit Preview Latest Commit
Image Edit on Studio ↗︎ View Live Preview 8da8f38

@danielroe danielroe added enhancement New feature or request provider labels Oct 20, 2023
@codecov-commenter

codecov-commenter commented Oct 20, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (58c5139) 89.66% compared to head (d876277) 90.04%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1066      +/-   ##
==========================================
+ Coverage   89.66%   90.04%   +0.37%     
==========================================
  Files          44       45       +1     
  Lines        2933     3044     +111     
  Branches      330      335       +5     
==========================================
+ Hits         2630     2741     +111     
- Misses        301      302       +1     
+ Partials        2        1       -1     
Files Coverage Δ
src/provider.ts 97.54% <100.00%> (+0.02%) ⬆️
src/runtime/providers/sirv.ts 100.00% <100.00%> (ø)
src/types/module.ts 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread src/runtime/providers/sirv.ts Outdated

@danielroe danielroe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great ❤️

@danielroe danielroe changed the title feat: sirv provider feat: add sirv provider Oct 22, 2023
@danielroe
danielroe merged commit 4360928 into nuxt:main Oct 22, 2023
riddla pushed a commit to tricks-gmbh/nuxt-image that referenced this pull request Mar 1, 2024
@github-actions github-actions Bot mentioned this pull request Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request provider

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants