fix(cloudimage): skip cdn when src path is provided with protocol - #1028
Merged
atinux merged 3 commits intoOct 4, 2023
Merged
Conversation
danielroe
reviewed
Oct 3, 2023
danielroe
reviewed
Oct 3, 2023
danielroe
requested changes
Oct 3, 2023
src path is provided
src path is providedsrc path is provided with protocol
danielroe
approved these changes
Oct 3, 2023
danielroe
left a comment
Member
There was a problem hiding this comment.
this looks good to me, thank you 👌
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1028 +/- ##
==========================================
- Coverage 89.69% 89.57% -0.12%
==========================================
Files 44 44
Lines 2920 2927 +7
Branches 328 329 +1
==========================================
+ Hits 2619 2622 +3
- Misses 300 304 +4
Partials 1 1
☔ View full report in Codecov by Sentry. |
atinux
approved these changes
Oct 4, 2023
riddla
pushed a commit
to tricks-gmbh/nuxt-image
that referenced
this pull request
Mar 1, 2024
…uxt#1028) * chore(cloudimage): add condition if url startwith http for cloudimage * chore(cloudimage): feedback Daniel * test: update snapshots for cloudimage --------- Co-authored-by: Daniel Roe <daniel@roe.dev>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
HTTPshould not be prefixed withBase Urlissues
Solution
startwith httpreturn src with generate query parametersBefore:
https://token.cloudimg.io/__path__/https://2412819702-files.gitbook.io/~/files/v0/b/gitbook-x-prod.appspot.com/o/spaces%2FlIgyYELwJG6odLEyCM6i%2Fuploads%2FAHcbuKRYbIlBWO4cJ88b%2Fimage.png?alt=media&token=62ff753d-83eb-4e3f-932c-96eb72d455f1?height=100&width=100&q=65&func=cropAfter:
https://2412819702-files.gitbook.io/~/files/v0/b/gitbook-x-prod.appspot.com/o/spaces%2FlIgyYELwJG6odLEyCM6i%2Fuploads%2FAHcbuKRYbIlBWO4cJ88b%2Fimage.png?alt=media&token=62ff753d-83eb-4e3f-932c-96eb72d455f1?height=100&width=100&q=65&func=cropRemaining