feat: add weserv provider - #1019
Merged
Merged
Conversation
✅ Live Preview ready!
|
danielroe
reviewed
Oct 2, 2023
danielroe
requested changes
Oct 2, 2023
danielroe
left a comment
Member
There was a problem hiding this comment.
Would you be able to add a few test cases for weserv in playground/providers.ts, test/unit/providers.test.ts and test/providers.ts? 🙏
Contributor
Author
Member
|
You can try running |
Contributor
Author
|
I know the correct url is generated, and when testing it by pasting it into the browser, I get the result I expected yet. The ssr and no-ssr tests are not working. Can you perhaps help me on this front? |
|
As per the request made in #962 (comment), I'd like to provide my feedback:
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1019 +/- ##
==========================================
+ Coverage 69.61% 70.16% +0.54%
==========================================
Files 72 73 +1
Lines 4131 4250 +119
Branches 385 392 +7
==========================================
+ Hits 2876 2982 +106
- Misses 1229 1243 +14
+ Partials 26 25 -1 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Daniel Roe <daniel@roe.dev>
danielroe
approved these changes
Dec 17, 2023
riddla
pushed a commit
to tricks-gmbh/nuxt-image
that referenced
this pull request
Mar 1, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Most options are in the keymap, the documentation is just a link to the website. That could be improved but frankly that's a lot of work. Maybe someone can put ai to use and summaries the doc for the provider documentation
Recreated as per: #962 (comment)