Skip to content

feat: add weserv provider - #1019

Merged
danielroe merged 29 commits into
nuxt:mainfrom
nandi95:wsrv
Dec 18, 2023
Merged

feat: add weserv provider#1019
danielroe merged 29 commits into
nuxt:mainfrom
nandi95:wsrv

Conversation

@nandi95

@nandi95 nandi95 commented Sep 30, 2023

Copy link
Copy Markdown
Contributor

Most options are in the keymap, the documentation is just a link to the website. That could be improved but frankly that's a lot of work. Maybe someone can put ai to use and summaries the doc for the provider documentation

Recreated as per: #962 (comment)

@ghost

ghost commented Sep 30, 2023

Copy link
Copy Markdown

Live Preview ready!

Name Edit Preview Latest Commit
Image Edit on Studio ↗︎ View Live Preview 305b1b8

Comment thread docs/content/3.providers/weserv.md Outdated

@danielroe danielroe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you be able to add a few test cases for weserv in playground/providers.ts, test/unit/providers.test.ts and test/providers.ts? 🙏

@nandi95

nandi95 commented Oct 2, 2023

Copy link
Copy Markdown
Contributor Author

Would you be able to add a few test cases for weserv in playground/providers.ts, test/unit/providers.test.ts and test/providers.ts? 🙏

Screenshot 2023-10-02 at 23 02 05

I can't seem to run the tests. I installed with pnpm and run the test with it but I get the above.

@danielroe

Copy link
Copy Markdown
Member

You can try running pnpm dev:prepare first.

@nandi95

nandi95 commented Oct 3, 2023

Copy link
Copy Markdown
Contributor Author

I know the correct url is generated, and when testing it by pasting it into the browser, I get the result I expected yet. The ssr and no-ssr tests are not working. Can you perhaps help me on this front?

@kleisauke

Copy link
Copy Markdown

As per the request made in #962 (comment), I'd like to provide my feedback:

  • Please consider replacing weserve with weserv.
  • Currently, https://wsrv.nl is hard-coded, and there's no flexibility to modify it. It's worth noting that many websites host their own solutions using our open-source code.

@nandi95
nandi95 requested a review from danielroe October 7, 2023 16:31
@codecov-commenter

codecov-commenter commented Nov 20, 2023

Copy link
Copy Markdown

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (bebad4f) 69.61% compared to head (277627b) 70.16%.

Files Patch % Lines
src/runtime/providers/weserv.ts 89.83% 12 Missing ⚠️
docs/pages/index.vue 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1019      +/-   ##
==========================================
+ Coverage   69.61%   70.16%   +0.54%     
==========================================
  Files          72       73       +1     
  Lines        4131     4250     +119     
  Branches      385      392       +7     
==========================================
+ Hits         2876     2982     +106     
- Misses       1229     1243      +14     
+ Partials       26       25       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielroe danielroe changed the title feat: add weserv provider feat: add weserv provider Dec 18, 2023
@danielroe
danielroe merged commit 42839d8 into nuxt:main Dec 18, 2023
@nandi95
nandi95 deleted the wsrv branch December 19, 2023 11:55
riddla pushed a commit to tricks-gmbh/nuxt-image that referenced this pull request Mar 1, 2024
@github-actions github-actions Bot mentioned this pull request Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants