Conversation
✅ Live Preview ready!
|
| link: [{ | ||
| rel: 'preload', | ||
| as: 'image', | ||
| // @ts-expect-error might need to resolve upstream in unhead |
There was a problem hiding this comment.
In the context of this PR, what's the preferred resolution here?
Wait for the new release of @unhead/vue to use zhead@^2.1.2? Or do you want me to update the comment here to something like fixed in zhead v2.1.2, needs upstream adoption by @unhead/vue?
There was a problem hiding this comment.
Good question, if you delete the lock file & node_modules it should update to this version and you can remove the comment altogether
There was a problem hiding this comment.
don't worry about refreshing lockfile in this pr; I can remove the comment when we next update deps....
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1012 +/- ##
==========================================
- Coverage 89.91% 89.68% -0.23%
==========================================
Files 44 44
Lines 2905 2919 +14
Branches 328 328
==========================================
+ Hits 2612 2618 +6
- Misses 292 300 +8
Partials 1 1
☔ View full report in Codecov by Sentry. |
As suggested in #1012 (comment)
|
Awesome! 🚀 |
5 participants
Implements #1011