Skip to content

refactor: use kit rc10 utilities#72

Merged
danielroe merged 5 commits into
mainfrom
refactor-nuxt-rc10
Sep 20, 2022
Merged

refactor: use kit rc10 utilities#72
danielroe merged 5 commits into
mainfrom
refactor-nuxt-rc10

Conversation

@Lexpeartha

Copy link
Copy Markdown
Collaborator

No description provided.

@Lexpeartha Lexpeartha added the enhancement New feature or request label Sep 20, 2022
@Lexpeartha Lexpeartha self-assigned this Sep 20, 2022
@vercel

vercel Bot commented Sep 20, 2022

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nuxt-ionic ✅ Ready (Inspect) Visit Preview Sep 20, 2022 at 1:45PM (UTC)

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #72 (74a7edb) into main (717f241) will increase coverage by 0.25%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##             main      #72      +/-   ##
==========================================
+ Coverage   92.79%   93.04%   +0.25%     
==========================================
  Files           8        8              
  Lines         444      446       +2     
  Branches       33       32       -1     
==========================================
+ Hits          412      415       +3     
+ Misses         32       31       -1     
Impacted Files Coverage Δ
src/parts/icons.ts 40.00% <50.00%> (-5.46%) ⬇️
src/module.ts 96.93% <100.00%> (+0.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@Lexpeartha

Copy link
Copy Markdown
Collaborator Author

Also, do you want me to upgrade docus in this, or another PR?

@danielroe

danielroe commented Sep 20, 2022

Copy link
Copy Markdown
Collaborator

Let's do it in another PR.

@Lexpeartha Lexpeartha marked this pull request as ready for review September 20, 2022 13:25
@danielroe

Copy link
Copy Markdown
Collaborator

Actually, it seems that the docs are broken in this PR (not your fault!) so maybe we have to resolve at the same time.

@Lexpeartha

Copy link
Copy Markdown
Collaborator Author

weird, locally docs work fine for me

@Lexpeartha

Lexpeartha commented Sep 20, 2022

Copy link
Copy Markdown
Collaborator Author

Just to confirm if I understood things correctly, docus in now implemented as a nuxt theme, correct?

@danielroe

Copy link
Copy Markdown
Collaborator

It is. But we might also wait until it's released.

@Lexpeartha

Copy link
Copy Markdown
Collaborator Author

Alright, I'll merge these changes then, and leave upgrading docus for another time

@Lexpeartha

Copy link
Copy Markdown
Collaborator Author

I reverted last commit, vercel build seems to be working now, no?

@danielroe

Copy link
Copy Markdown
Collaborator

Yep - sorry, didn't spot it.

@danielroe danielroe changed the title refactor: update to nuxt rc10 refactor: use kit rc10 utilities Sep 20, 2022
@danielroe danielroe merged commit 8e64ed4 into main Sep 20, 2022
@danielroe danielroe deleted the refactor-nuxt-rc10 branch September 20, 2022 13:58
@github-actions github-actions Bot mentioned this pull request Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants