Skip to content

chore(playground): update type in ionic.config.json#602

Merged
danielroe merged 1 commit into
nuxt-modules:mainfrom
oumarbarry:patch-1
Aug 12, 2024
Merged

chore(playground): update type in ionic.config.json#602
danielroe merged 1 commit into
nuxt-modules:mainfrom
oumarbarry:patch-1

Conversation

@oumarbarry

Copy link
Copy Markdown
Contributor

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

Update the ionic.config.json of the playground, by changing the type to custom:

{
  "type": "custom"
}

This ensures Ionic uses the correct CLI, Nuxi, instead of expecting the Vite CLI when the type is set to vue-vite as in the reference here.

@oumarbarry oumarbarry requested a review from danielroe as a code owner August 12, 2024 20:53
@netlify

netlify Bot commented Aug 12, 2024

Copy link
Copy Markdown

Deploy Preview for friendly-lamington-fb5690 canceled.

Name Link
🔨 Latest commit db3e779
🔍 Latest deploy log https://app.netlify.com/sites/friendly-lamington-fb5690/deploys/66ba762efa686b0008c6653a

@codecov

codecov Bot commented Aug 12, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.33%. Comparing base (2f60d10) to head (db3e779).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #602   +/-   ##
=======================================
  Coverage   46.33%   46.33%           
=======================================
  Files          11       11           
  Lines         669      669           
  Branches       27       27           
=======================================
  Hits          310      310           
  Misses        359      359           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danielroe danielroe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! ❤️

@danielroe danielroe merged commit 0bb5bd2 into nuxt-modules:main Aug 12, 2024
@oumarbarry oumarbarry deleted the patch-1 branch August 12, 2024 22:58
@github-actions github-actions Bot mentioned this pull request Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants