feat: add IonAnimation component#40
Conversation
|
Someone is attempting to deploy a commit to a Personal Account owned by @danielroe on Vercel. @danielroe first needs to authorize it. |
Codecov Report
@@ Coverage Diff @@
## main #40 +/- ##
==========================================
+ Coverage 92.18% 92.22% +0.03%
==========================================
Files 7 8 +1
Lines 448 463 +15
Branches 37 38 +1
==========================================
+ Hits 413 427 +14
- Misses 35 36 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Co-authored-by: Daniel Roe <daniel@roe.dev>
|
Worth noting than in future with more components it would make more sense to use |
|
Also what do you say I create 4th tab in playground showcasing all animations from the ionic docs with this component? |
|
4th tab sounds great! |
|
I think core component is ready. Only thing left is maybe more animation examples, and updating the docs |
|
Only thing I'm not really sure how to approach is grouped animation. It allows for using one root animation, to play children animations in parallel. However to do this, I think I need a better way than scoped slot to expose animation object to page/component it is being using in. Any ideas? |
|
@danielroe Could you take a look at docs? Is this enough of documentation for such a component with lots of props, or should I be more thorough? |
Also about exposing an animation object, I tried to do some |
|
I'm merging the PR. If you think docs need more work lmk, but I think component is straight-forward enough that this will do |
Resolves #34
I'm looking for a feedback, mostly regarding component's API
This PR is still WIP