feat: upgrade to ionic 7#318
Merged
Merged
Conversation
✅ Deploy Preview for friendly-lamington-fb5690 ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Contributor
Author
|
@danielroe |
Collaborator
|
You're right, I think we can omit it now. |
danielroe
approved these changes
Apr 6, 2023
|
@danielroe did you forget to trigger a new version of the package or are you waiting for something else? 😋 |
Collaborator
|
don't lose heart - coming soon! |
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ion-slides and ion-slide components have been removed in favor of using Swiper.js directly. The nuxt-swiper module can be used in place.
The ion-virtual-scroll component has been removed in favor of using solutions provided by each JavaScript Framework.
vue-virtual-scroller can be used in place per example.
The packages @ionic/vue and @ionic/vue-router have been updated to no longer include a CommonJS entry point, and now only provide an ES Module entry point. This change has been made to improve compatibility with Vite.
Regarding the optimization of these packages, the question is whether it's still necessary to include '@ionic/vue' in the 'vite.optimizeDeps.include' array.