Give the LLM client a request timeout so a hung provider can't stall the agent - #6
Merged
Merged
Conversation
The manual merge of main mistyped the env parsing lines: ',' became '||' (dropping the fallback argument), temperature used intFromEnv instead of floatFromEnv, and one call was misspelled as pintFromEnv. Restore the intended calls, with timeoutMs also validated via intFromEnv.
nullcache
force-pushed
the
fix/llm-request-timeout
branch
from
August 17, 2026 03:24
c2f8d21 to
7bca881
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was running this against a flaky proxy the other day and hit something annoying: the agent would just sit there — no output, nothing. Turns out fetch() doesn't have a timeout. Node silently drops the timeout option if you pass it, so if a provider accepts the connection and then never answers, you're stuck until you hit Ctrl+C.
So the LLM client now takes a timeoutMs (default 5 min, overridable with CORECODER_TIMEOUT_MS) and every request races against a timer. If the timer wins, it aborts the fetch and the retry loop treats it as a transient error and retries. Your own Ctrl+C still comes through as an AbortError — the timeout can't swallow it.
Three tests cover it:
Writing the tests caught something fun: my fetch stub didn't reject when handed an already-aborted signal, so the second test hung forever. Real fetch rejects immediately in that case, so I fixed the stub, not the client.
Design note: the timeout covers getting a response, not the streaming body — a model that's actively streaming can legitimately take a while, and that's Ctrl+C territory. Say the word if you'd rather have a whole-call timeout instead.