Replaced __internal__ argument with module attribute#15
Conversation
3feb256 to
12bce1c
Compare
|
While I'm not against the idea, I would worry about race conditions causing the |
|
@hugovk did you have a preference here? |
|
Is the idea to prevent deprecation warnings being raised when we're calling deprecated code internally? Ideally we shouldn't call deprecated code internally, because it's going to go away, but in the short term, can we catch the warning when called internally with something like |
|
The I wasn't aware of https://docs.python.org/3/library/warnings.html#temporarily-suppressing-warnings (emphasis mine)
|
|
Ok, I've created #19 instead. |
Suggestion for #6381
Rather than adding an
__internal__argument to method definitions, this PR adds and removes a_deprecate._suppress_internal_deprecationssetting.This may or may not be preferable. See what you think.