Skip to content

Run golangci-lint in runner CI (not just go vet) #477

Open

Description

@mayankpande88

The repo ships a runner/.golangci.yml config and the make lint target supports golangci-lint, but the runner CI workflow should actually run golangci-lint rather than only go vet. This catches a much wider class of issues on every PR.

Goal

Ensure golangci-lint runs in CI for the runner using the committed .golangci.yml.

Scope

  • Verify whether .github/workflows/runner-lint-test.yaml currently runs golangci-lint. If it only runs go vet, add the official golangci/golangci-lint-action step (pinned version) pointed at the runner/ module.
  • Make sure it uses the existing runner/.golangci.yml config.
  • Confirm the job passes on the current main (fix or report any newly surfaced lint findings; large fixes can be split into follow-up PRs).

Pointers

  • .github/workflows/runner-lint-test.yaml
  • runner/.golangci.yml
  • runner/Makefile (make lint)

Acceptance

  • CI runs golangci-lint on PRs that touch the runner and the check is green on main.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions