Repository navigation
fix(nb-41478): make shipped templates pass Validate, and check it in CI - #17
Open
Kankshit-02 wants to merge 1 commit into
Open
Kankshit-02 wants to merge 1 commit into
Kankshit-02 wants to merge 1 commit into
Conversation
Five templates failed the engine's Validate with no edits: ArgoCD Sync missed integration_id on its argocd steps, SSL Monitor and Multi-Endpoint Health used a templated cron the engine rejects at save, K8s Right-Sizing missed direction, and two data.transform steps passed a map as input. - ArgoCD Sync asks for the ArgoCD integration in the template form. - SSL Monitor and Multi-Endpoint Health use a literal cron. - K8s Right-Sizing no longer runs k8s.vertical_rightsize before approval (that task patches the workload); the approved step scales CPU and memory up or down by 20%, direction asked in the form. - Multi-Endpoint Health and Scheduled Ping pass transform input as a JSON string and read it from `data`, the only name the engine exposes. - validate.py checks each task's required params (from the engine's input schemas) and that schedule crons are literal; unit tests run in CI. Fixes nudgebee/nudgebee-enterprise#41478 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
mayankpande88
approved these changes
Nov 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Five pre-built templates failed Validate right after Use Template, with no edits. They now pass, and CI fails any template that is missing a required step value or uses a templated schedule. K8s Right-Sizing also stopped resizing the workload before approval.
Fixes nudgebee/nudgebee-enterprise#41478
Type of change
How Has This Been Tested?
integration_idfrom any ArgoCD step, or put{{ Inputs.x }}in a cron, and CI fails naming the template and step.Risks
integration_namein the file. The template form already asks for it (#41658 on enterprise), so CI does not check it.scripts/validate.py(different spots), and fix(nb-41480): ask before crashloop remediation and argocd sync #12 touches the ArgoCD template (different lines). TheRun unit testsstep invalidate.yamlmatches fix(nb-41479): require region and drop placeholder defaults in templates #13's line exactly.Tasks.x.output.flag, but the engine stores it underoutput.data(executor.go:390). Theirif:conditions are never true. Will be filed as its own ticket.Engineering detail: how each fix was checked against the engine
tasks.NewInitializedTaskRegistry(): properties withRequiredand noDefault(the engine fills defaults before its required check)model.ValidateWorkflow,ValidateDAG,ValidateTemplateSyntax,ValidateUnrenderedInputsand each task/hookInputSchema().Validateon all 51 files. Only remaining error: webhookintegration_name, filled by the forminputwithworkflow.NewTemplateContextand randata.TransformTaskwith sample inputs, including skipped checks (empty statuses)model.ValidateCronExpression: stripsCRON_TZ=/TZ=, accepts 5 fields or@descriptor, rejects{{ }}k8s.vertical_rightsizewith onlydirectionpatches nothing (no cpu/memory rules), sochange_pct: 20is set on bothFresh-context review found 4 issues in
validate.py: a required-with-default false positive (k8s.pv_rightsize.kind), missingk8s.profile, TZ-prefix and@dailycrons rejected, and a crash on non-dict params. All fixed and covered by tests.🤖 Generated with Claude Code