Ability to mock protected methods with and without return value - #845
Merged
Conversation
Jason31569
changed the title
dtchepak
approved these changes
Dec 8, 2024
… unit tests to verify error conditions * Rename unit tests with better description * Fix unit test failure due to orphaned argument spec when previous setup throws
|
holding my breath for this one. |
Member
|
Hi @Romfos , Just wanted to check you're happy with this change? |
Contributor
|
@dtchepak sorry, I'm not fully qualified how this part of code is working. Could you please review by yourself? |
Contributor
Author
|
@dtchepak let me know if you have any additional suggestions or if you're happy to merge this? Thank you. |
dtchepak
approved these changes
Mar 9, 2025
dtchepak
left a comment
dtchepak
left a comment
Member
There was a problem hiding this comment.
Sorry for the delay. Looks great, thanks!
Merged
This was referenced Jul 12, 2026
This was referenced Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #800