refactor: move hostapd_radius_attr into common - #469
Merged
mereacre merged 3 commits intoMar 1, 2023
Conversation
Move `struct hostapd_radius_attr` from `src/radius/radius_server.h` to `src/radius/common.h`. It's used by the hostapd source-code to store RADIUS attributes. See https://w1.fi/cgit/hostap/commit/?id=af35e7af7f8bb1ca9f0905b4074fb56a264aa12b Co-authored-by: Alexandru Mereacre <mereacre@gmail.com>
Draft
Codecov Report
@@ Coverage Diff @@
## main #469 +/- ##
=======================================
Coverage 53.48% 53.48%
=======================================
Files 144 144
Lines 19963 19963
=======================================
+ Hits 10677 10678 +1
+ Misses 9286 9285 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mereacre
approved these changes
Feb 28, 2023
mereacre
deleted the
refactor/move-hostapd_radius_attr-into-radius-common
branch
March 1, 2023 10:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move
struct hostapd_radius_attrfromsrc/radius/radius_server.htosrc/radius/common.h.I'm guessing this is to keep
src/radius/radius_server.has close to the upstreamhostapdsource-code as possible.It's used by the hostapd source-code to store RADIUS attributes.
See
https://w1.fi/cgit/hostap/commit/?id=af35e7af7f8bb1ca9f0905b4074fb56a264aa12b
Adapted from dff384c. I've instead used
uint8_tinstead ofu8, to match standard ISO C types, and added documentation.