refactor(supervisor_config): include radius_config - #449
Merged
aloisklink merged 2 commits intoFeb 28, 2023
Conversation
Add an `#include "../radius/radius_config.h"` to `supervisor_config.h`. This file uses the `struct radius_conf` type since 24c49d5 (wip: ap event manager, 2021-09-07), but never directly included the file that defines `struct radius_conf`. See 24c49d5 Co-authored-by: Alexandru Mereacre <mereacre@gmail.com>
Draft
Codecov Report
@@ Coverage Diff @@
## main #449 +/- ##
=======================================
Coverage 53.08% 53.08%
=======================================
Files 144 144
Lines 19871 19871
=======================================
Hits 10548 10548
Misses 9323 9323 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Contributor
|
I think I had some issue with recursive definitions. But as long as it compiles fine, shouldn't be no problem. |
aloisklink
marked this pull request as ready for review
February 24, 2023 10:30
aloisklink
enabled auto-merge
February 24, 2023 10:30
mereacre
self-requested a review
February 28, 2023 09:48
mereacre
approved these changes
Feb 28, 2023
aloisklink
deleted the
refactor/include-radius_config-in-supervisor_config
branch
February 28, 2023 10:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an
#include "../radius/radius_config.h"tosupervisor_config.h.This file uses the
struct radius_conftype since 24c49d5, which is defined in../radius/radius_config.h, so we should include that file directly.This was changed in 2704b75#diff-c92e4b6dccbcdfb60672a8b00773227eddcc9c4ba6ee87a3ac46dcef04b41b4cR19, but I'm not 100% sure why.
I think @mereacre did it because there's
struct radius_confin this file, so that's what I've stuck in this PR/commit description (if I'm wrong, let me know @mereacre).