feat(os): add os_strncmp definition - #430
Merged
Merged
Conversation
Source-code taken from the hostap project expect a `os_strncmp` call that points to `strncmp`.
Draft
Codecov Report
@@ Coverage Diff @@
## main #430 +/- ##
=======================================
Coverage 53.09% 53.09%
=======================================
Files 144 144
Lines 19880 19880
=======================================
Hits 10555 10555
Misses 9325 9325
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mereacre
approved these changes
Feb 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Source-code taken from the hostap project expects a
os_strncmpcall that points tostrncmp.Adapted from commit https://github.com/nqminds/edgesec/commits/12d15b2405aa6f2ab39a31d880499f8fc6f84c02, which instead names this macro
sys_strncmp.edgesec/src/utils/os.h
Lines 67 to 69 in 12d15b2
Using
os_strncmpis a lot easier, since then we can avoid changing any of the hostap code.