refactor(os): rename os_get_reltime with edge_ - #417
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #417 +/- ##
=======================================
Coverage 53.08% 53.08%
=======================================
Files 144 144
Lines 19883 19883
=======================================
Hits 10555 10555
Misses 9328 9328
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mereacre
approved these changes
Feb 17, 2023
aloisklink
enabled auto-merge
February 17, 2023 13:44
Rename `os_get_reltime` to `edge_os_get_reltime` to avoid linking conflicts with the `os_get_reltime` from libeap. Use a `#define os_get_reltime edge_os_get_reltime` instead of renaming the function everywhere in our source code.
aloisklink
force-pushed
the
refactor/rename-os_get_reltime
branch
from
February 17, 2023 14:35
90e328f to
abc4484
Compare
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
os_get_reltimetoedge_os_get_reltimeto avoid linking conflicts with theos_get_reltimefrom libeap.Use a
#define os_get_reltime edge_os_get_reltimeinstead of renaming the function everywhere in our source code.Adapted from a873368, which renamed
os_get_reltimetoget_reltime, and didn't create a macro foros_get_reltime, so it had to be renamed in a bunch of places.