refactor(os): inline hex2byte and remove from os.h - #415
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## main #415 +/- ##
=======================================
Coverage 53.08% 53.08%
=======================================
Files 144 144
Lines 19883 19883
=======================================
Hits 10555 10555
Misses 9328 9328
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
mereacre
approved these changes
Feb 17, 2023
aloisklink
enabled auto-merge
February 17, 2023 13:44
Inline the hex2byte function, and remove it from src/utils/os.h We never call it outside of this function, but it may cause linking errors with libeap. Co-authored-by: Alois Klink <alois@nquiringminds.com>
aloisklink
force-pushed
the
refactor/inline-hex2byte
branch
from
February 17, 2023 14:34
06dba6c to
c7e7777
Compare
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inline the
hex2bytefunction, and remove it fromsrc/utils/os.hWe never call it outside of this file, but it may cause linking errors with libeap.
Adapted from b273cce
The main difference is that instead of renaming the function, if we just inline it, this avoids linker issues (there were also some merge conflicts to fix).