Skip to content

build(tests): disable LTO for tests - #363

Merged
aloisklink merged 3 commits into
mainfrom
build/disable-lto-for-tests
Dec 9, 2022
Merged

build(tests): disable LTO for tests#363
aloisklink merged 3 commits into
mainfrom
build/disable-lto-for-tests

Conversation

@aloisklink

Copy link
Copy Markdown
Contributor

Link time optimization (LTO) seems to be causing some issues when doing -Wl,--wrap (e.g. link-time mocking).

See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88643 and https://sourceware.org/bugzilla/show_bug.cgi?id=24415 for the bug reports.

Fixes a undefined reference to `log_levels' when compiling wrap_log_levels in the debian build (which uses -flto=auto).

Link time optimization seems to be causing some issues when doing
-Wl,--wrap (e.g. link-time mocking).

See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=88643 and
https://sourceware.org/bugzilla/show_bug.cgi?id=24415
@codecov

codecov Bot commented Dec 9, 2022

Copy link
Copy Markdown

Codecov Report

Merging #363 (a9a8181) into main (6ca0b12) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head a9a8181 differs from pull request most recent head fc25550. Consider uploading reports for the commit fc25550 to get more accurate results

@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
+ Coverage   51.77%   51.81%   +0.04%     
==========================================
  Files         139      139              
  Lines       19318    19317       -1     
==========================================
+ Hits        10002    10010       +8     
+ Misses       9316     9307       -9     
Impacted Files Coverage Δ
src/utils/os.c 50.43% <0.00%> (+0.05%) ⬆️
src/ap/ap_service.c 52.00% <0.00%> (+4.57%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@aloisklink
aloisklink merged commit 8316437 into main Dec 9, 2022
@aloisklink
aloisklink deleted the build/disable-lto-for-tests branch December 9, 2022 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants