Fix -Wformat-security errors - #360
Merged
Merged
Conversation
This is mainly to make GCC happy when compiling under truncation warning flags.
strncpy is not guaranteed to write a nul terminator.
Debian builds compile with -Wformat-security enabled. See <https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html> for docs.
Codecov Report
@@ Coverage Diff @@
## main #360 +/- ##
==========================================
+ Coverage 51.77% 51.80% +0.03%
==========================================
Files 139 139
Lines 19313 19317 +4
==========================================
+ Hits 9999 10008 +9
+ Misses 9314 9309 -5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
aloisklink
enabled auto-merge
December 9, 2022 13:45
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Debian builds compile with
-Wformat-securityenabled.This PR enables this flag, and fixes those errors.
See https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html for docs.
This caught a potential truncation bug in
dnsmasq.cand a potential buffer overflow insqlhook.c