Skip to content

fix(i18n): use more explicit description in chart embed tooltip#3046

Merged
graphieros merged 1 commit into
npmx-dev:mainfrom
graphieros:fix-embed-tip-translation
Jul 15, 2026
Merged

fix(i18n): use more explicit description in chart embed tooltip#3046
graphieros merged 1 commit into
npmx-dev:mainfrom
graphieros:fix-embed-tip-translation

Conversation

@graphieros

Copy link
Copy Markdown
Member

🔗 Linked issue

See @userquin 's comment in #3040

🧭 Context

The description in the tooltip was not explicit enough.

📚 Description

The updated description makes it more explicit endDate and startDate are part of the embed URL

@vercel

vercel Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Jul 15, 2026 3:23pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Jul 15, 2026 3:23pm
npmx-lunaria Ignored Ignored Jul 15, 2026 3:23pm

Request Review

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 33f5e6a9-89b2-4ae9-a0f2-0c30a95211c7

📥 Commits

Reviewing files that changed from the base of the PR and between 5bbce3e and 692cd40.

📒 Files selected for processing (1)
  • i18n/locales/en.json

📝 Walkthrough

Summary by CodeRabbit

  • Documentation
    • Clarified guidance for embedded charts: URL parameters can set the start and end dates.
    • Explained that charts default to displaying the previous 12 months when no dates are provided.

Walkthrough

Changes

Embedded chart copy

Layer / File(s) Summary
Clarify embedded chart date parameters
i18n/locales/en.json
The embedded chart tip now references startDate and endDate in the URL and states that the graph defaults to the last 12 months when they are absent.

Suggested reviewers: alexdln, 43081j, adebesin-cell

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarises the tooltip wording update for chart embeds.
Description check ✅ Passed The description matches the change and explains that the embed URL parameters are being made explicit.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
i18n/locales/en.json Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@graphieros
graphieros added this pull request to the merge queue Jul 15, 2026
@codecov

codecov Bot commented Jul 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Merged via the queue into npmx-dev:main with commit 53acd4a Jul 15, 2026
25 checks passed
@graphieros
graphieros deleted the fix-embed-tip-translation branch July 15, 2026 15:31
@github-actions github-actions Bot mentioned this pull request Jul 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants